Skip to content

doc(gh-2187): enhance documentation for Bernoulli and Binomial distributions#2192

Merged
fehiepsi merged 2 commits into
masterfrom
doc-bernoulli-binomial-distributions
May 23, 2026
Merged

doc(gh-2187): enhance documentation for Bernoulli and Binomial distributions#2192
fehiepsi merged 2 commits into
masterfrom
doc-bernoulli-binomial-distributions

Conversation

@Qazalbash
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor questions.

Comment thread docs/source/conf.py
Comment thread numpyro/distributions/discrete.py
Comment thread numpyro/distributions/discrete.py
@Qazalbash Qazalbash requested a review from juanitorduz May 21, 2026 10:03
@Qazalbash
Copy link
Copy Markdown
Collaborator Author

@juanitorduz how you are using Claude to review code?

@juanitorduz
Copy link
Copy Markdown
Collaborator

@juanitorduz how you are using Claude to review code?

Just pull the branch of the PR locally and then use Claude Code 🤖

Copy link
Copy Markdown
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!!

@fehiepsi fehiepsi merged commit 72c5ed4 into master May 23, 2026
9 checks passed
@fehiepsi fehiepsi deleted the doc-bernoulli-binomial-distributions branch May 23, 2026 11:02
Qazalbash added a commit that referenced this pull request May 28, 2026
* doc(gh-2187): enhance documentation for Gumbel, Laplace, and Logistic distributions

Adds math-flavored docstrings to three more continuous distributions on the
#2187 checklist, following the template from #2188, #2192, and #2199:

- Gumbel: class, __init__, sample, log_prob, mean, variance, cdf, icdf.
- Laplace: class, __init__, sample, log_prob, mean, variance, cdf, icdf, entropy.
- Logistic: class, __init__, sample, log_prob, mean, variance, cdf, icdf, entropy.

Docstrings only, no logic changes. ruff check and ruff format --check are
clean.

* fix: small fixes

---------

Co-authored-by: Meesum Qazalbash <meesumqazalbash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants