Skip to content

build: switch to pyproject.toml#1891

Closed
nstarman wants to merge 3 commits intopyro-ppl:masterfrom
nstarman:rm-setup.py
Closed

build: switch to pyproject.toml#1891
nstarman wants to merge 3 commits intopyro-ppl:masterfrom
nstarman:rm-setup.py

Conversation

@nstarman
Copy link
Contributor

@nstarman nstarman commented Oct 16, 2024 •
edited
Loading

Requires #1892

@nstarman nstarman force-pushed the rm-setup.py branch 4 times, most recently from 838620c to 9df98f1 Compare October 16, 2024 22:03
@nstarman nstarman marked this pull request as ready for review October 16, 2024 22:04
@nstarman
Copy link
Contributor Author

nstarman commented Oct 16, 2024

The version is now specified 2x, in numpyro.version.py::__version__ and in pyproject.toml.
I could fix that in this PR or in a followup. Don't know exactly what it will take, possibly importlib.metadata will work. Or maybe setuptools_scm dynamic version writing.

@nstarman
build: switch to pyproject.toml
3ef82e8 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
build: bump setuptools
f3fe8a9 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
ci: apply fixes
e33c95d 
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman
Copy link
Contributor Author

nstarman commented Oct 16, 2024 •
edited
Loading

Needed to incorporate changes from the recent Jax NS fixes PR.

fehiepsi
fehiepsi reviewed Oct 17, 2024
View reviewed changes
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's good to use setup.py for version handling?

pyproject.toml
readme = "README.md"
requires-python = ">=3.9"
authors = [
{ name = "Uber AI Labs", email = "npradhan@uber.com" },
Copy link
Member

@fehiepsi fehiepsi Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use my email fehiepsi at gmail com for this.

pyproject.toml
"Operating System :: MacOS :: MacOS X",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
Copy link
Member

@fehiepsi fehiepsi Oct 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you also add 3.12

@nstarman
Copy link
Contributor Author

nstarman commented Oct 17, 2024

There are many pyproject.toml based solutions, it's just about choosing one. Do you want to manually bump the version or automatically using version control? Or use tooling like commitizen or GH actions?

@fehiepsi
Copy link
Member

fehiepsi commented Oct 17, 2024 •
edited
Loading

I would prefer having a minimal setup.py file for it and manually bump the version. Not sure if versioning is the reason jax team still keeps it.

@fehiepsi fehiepsi mentioned this pull request Dec 5, 2024
Closed
@Qazalbash
Copy link
Collaborator

Qazalbash commented Feb 9, 2026

I need pyproject.toml to complete #2129. If this PR is no longer active, would it be okay for me to use the existing pyproject.toml, or is @nstarman planning to continue working on it in the near future?

@nstarman
Copy link
Contributor Author

nstarman commented Feb 10, 2026

Go for it

@Qazalbash
Copy link
Collaborator

Qazalbash commented Feb 15, 2026

Closing this PR in favour of #2141.

@Qazalbash Qazalbash closed this Feb 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fehiepsi fehiepsi fehiepsi left review comments

Assignees

No one assigned

Labels

awaiting response

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nstarman @fehiepsi @Qazalbash