Warn about artifact action behavior for wheel matrices#2040
Merged
Warn about artifact action behavior for wheel matrices#2040
Conversation
Member
|
I think this should be a tip, not a warning. That issue was filed years ago and nobody uses v3. So I don't see why we need to highlight it. Today, I'd rather have a shorter note along the lines of "when building multiple wheels, you'll end up needing using uniquely named artifacts per build job". |
Contributor
Author
|
Thanks, agreed. I pushed c2b1179 to make this a short tip instead, without the old v3/v4 framing. Checked locally with |
webknjaz
reviewed
May 5, 2026
Member
|
Given https://www.dayswithoutgithubincident.com, it may take a few attempts to merge. |
Member
|
This one might actually be legit:
(though unrelated to the PR) |
Member
|
A rerun passed. So it was flaky. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a warning before the artifact upload/download workflow example for people adapting the guide to several platform-specific wheel jobs.
The sample now uses current artifact actions rather than the older v3 versions mentioned in the issue, so this keeps the caution framed around the still-relevant v4+ behavior: don't have multiple wheel jobs upload to the same artifact name; give each job its own artifact and adjust downloads accordingly.
Checks:
Fixes #1454
📚 Documentation preview 📚: https://python-packaging-user-guide--2040.org.readthedocs.build/en/2040/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/#checking-out-the-project-and-building-distributions