Correct calculation of search size for RTT CB detection (fix #1729)#1900
Closed
tenbaht wants to merge 1 commit intopyocd:mainfrom
Closed
Correct calculation of search size for RTT CB detection (fix #1729)#1900tenbaht wants to merge 1 commit intopyocd:mainfrom
tenbaht wants to merge 1 commit intopyocd:mainfrom
Conversation
To ensure a minimum size of 32 for the search range it is required to use max(search_size,32). Using min(search_size,32) reduces the given value for search size to a maximum of 32 - pretty much the opposite of the desired outcome.
Author
|
The already existing pull request #1730 fixes this issue in a better way. Please merge that one instead. |
Collaborator
|
Closing, as #1730 has been merged, per the request above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To ensure a minimum size of 32 for the search range it is required to use max(search_size,32). Using min(search_size,32) reduces the given value for search size to a maximum of 32 - pretty much the opposite of the desired outcome.