Issue 4902: Fix linewidth of stroked text.#4937
Merged
robinwatts merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
julian-smith-artifex-com
requested changes
Mar 12, 2026
Collaborator
julian-smith-artifex-com
left a comment
julian-smith-artifex-com
left a comment
There was a problem hiding this comment.
Looks good.
Formatting things:
- Please remove tab chars.
- Use
{...}even for single-line blocks. - Use 4-char indentation.
This relies on an upstream fix from MuPDF that will be in the 1.28.0 release, but is not in 1.27.2. There is a subtle change here; we now return linewidth as None for filled spans, rather than a bogus value.
julian-smith-artifex-com
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relies on an upstream fix from MuPDF that will be in the 1.28.0 release, but is not in 1.27.2.