Open
Conversation
Could destroy update information in duplicated graphs (like Scan likes to produce)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two unrelated issues found in pymc-devs/pymc#8243
sidestep_unused_rng_consumercould be too eager. Sometimes the output and the rng update are present in separate nodes that will eventually be merged together. Scan was doing this by cloning it separately due to implicit update machinery (deprecated API) that TruncatedRV in PyMC was still using. The explicit API doesn't clone/duplicate nodes, but we should still be on the guard.The fix is to not perform the rewrite if the input RNG has multiple clients. This is either a likely wrong graph, or something that will be merged and can then be rewritten or not.