Do not redefine Disconnected type every time #1837
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
disconnected_type
branch
from
4281bbb to
7ef9f73
Compare
jessegrabowski
approved these changes
Jan 11, 2026
ricardoV94
force-pushed
the
disconnected_type
branch
from
7ef9f73 to
7790a0c
Compare
Member
Author
|
failing test is sus. I wouldn't expect it to be relate to the changes, maybe numpy/scipy version change? However I can't rule it out until I see the failure arising in an another PR |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's wasteful to always redefine the type of the disconnected variables.
This PR includes commits from #1828