Consider numba fastmath config in cache key #1810
Merged
+1
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrabowski
approved these changes
Jan 2, 2026
Member
|
+1/-2 , finally a PR i can handle |
Member
Author
Only half of a human context window. Maybe we should try to quantize PRs into 5+-2 chunks. In expectation they will still do the right thing over time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought numba included this in its compilation key, but it does not.
I couldn't come up with a simple test, but the logic is pretty self-contained. Worst case scenario we would be doing nothing.
Came up in pymc-devs/pymc#7993