Clone inner graph ops #1809
Merged
Clone inner graph ops #1809
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessegrabowski
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused a failure in pymc-devs/pymc#7993, where evaluating a CustomDist with a Scan in numba mode would then fail to derive the logp, because of the introduction of RandomVariableWithCoreShape in the graph.
Also took the chance to remove CompositeF32 logic that is not used anywhere. This was likely used in the past to increase the number of nodes that could be fused together by converting f16 to f32, but it's not used anywhere now and costs us LOC. It's straightforward to readd logic when we feel the need for it again. Note with numba being the default backend f16 is basically not supported anyway