Numba RVs: Include output_bc_pattern in cache key #1804
Merged
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Dec 27, 2025
| core_shape_len, | ||
| inplace, | ||
| input_bc_patterns, | ||
| output_bc_patterns, |
Member
Author
There was a problem hiding this comment.
The fix is adding this to the key, the other changes are just simplification
Size is ignored when the output_bc_pattern implies it must be length 1, but shouldn't be ignored otherwise
ricardoV94
force-pushed
the
fix_numba_rv_cache_key
branch
from
c49ff4f to
a7b7185
Compare
jessegrabowski
approved these changes
Dec 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size is ignored when the output_bc_pattern implies it must be length 1, but shouldn't be ignored otherwise
Evaluating
pt.random.dirichlet(..., size=(2,))after having evaluated withsize=(1,)would return only 1 draw due to reusing the cached first function, which ignored the redundant runtime size.Issue found in pymc-devs/pymc#7993