Numba Dirichlet: Fix case with discrete alpha parameter #1801
+42
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
commented
Dec 26, 2025
| @numba_basic.numba_njit | ||
| def random_fn(rng, alpha): | ||
| y = np.empty_like(alpha) | ||
| y = np.empty_like(alpha, dtype=dtype) |
Member
Author
There was a problem hiding this comment.
If this was created as integers the line y[i] = ... would implicitly cast the gamma draws back to integer, but those must be floats for the output to make sense
Also handle core op caching key to support per-op invalidation
ricardoV94
force-pushed
the
fix_numba_discrete_alpha_dirichlet
branch
from
87e2f63 to
e42c853
Compare
jessegrabowski
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also handle core op caching key to support per-op invalidation
Found in pymc-devs/pymc#7993