facts.zfs: request parsable, exact, numbers#1501
Closed
Pirols wants to merge 1 commit intopyinfra-dev:3.xfrom
Closed
facts.zfs: request parsable, exact, numbers#1501Pirols wants to merge 1 commit intopyinfra-dev:3.xfrom
Pirols wants to merge 1 commit intopyinfra-dev:3.xfrom
Conversation
Both `zfs get` and `zpool get` have a `-p` option to request parsable (exact) output. ``` dpool size 266287972352 - dpool size 248G - ```
Fizzadar
reviewed
Dec 2, 2025
Member
Fizzadar
left a comment
Fizzadar
left a comment
There was a problem hiding this comment.
Small issue because the tests aren't updated to the new output format. Once fixed this means it's (annoyingly) a breaking change to the fact. One option is we could parse the exact (byte, I assume?) value and call it size_bytes and then we can generate size as a human friendly string from the bytes to maintain backwards compatibility. How does that sound?
| requires_command: zfs | ||
| output: | | ||
| tank type filesystem - | ||
| tank size 2.71T - |
Member
There was a problem hiding this comment.
Test isn't updated to match the change (same w/ others).
Member
|
Closing as stale |
Contributor
Author
Yes, sorry. Did not have time for this. Perhaps I will re-open at some point. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
zfs getandzpool gethave a-poption to request parsable (exact) output.3.xat this time)scripts/dev-test.sh)scripts/dev-lint.sh)