Open
Conversation
non-base conda environments lack bin/conda apply same solution as pyenv#290
detect base conda by testing for `envs` directory create or clone accordingly
native-api
requested changes
Oct 14, 2022
Member
native-api
left a comment
There was a problem hiding this comment.
There are tests that specifically check this use case. Those need to be adjusted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pyenv virtualenvfails to create conda environments from conda environments.Instead, it attempts to make python venv environments.
These updates reuse logic from #290 to detect conda environments, detect conda base environments, and clone non-base environments supplied as version to
pyenv virtualenv.