pbio/drv/bluetooth_btstack: Generalizations to prepare for POSIX variant. #442
+97
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed for the POSIX port, so we don't have to make special handlers to protect init from running twice.
Most BTstack ports do it this way, including embedded variants. This will let us use the POSIX libusb variant without modifying it.
This is needed for the POSIX port, which needs to poll files.
Co-authored-by: James Aguilar <aguilar.james@gmail.com>
dlech
reviewed
Dec 23, 2025
| uint16_t manufacturer; | ||
| /** LMP/PAL subversion. */ | ||
| uint16_t lmp_pal_subversion; | ||
| } pbdrv_bluetooth_btstack_device_discriminator_t; |
Member
There was a problem hiding this comment.
I would put local_version_info in the name rather than device_discriminator. The latter describes one use for it, but the former describes what it actually is and where it came from.
This is just an unpacked version of the return values from HCI Read Local Version Info.
| // not used | ||
| } | ||
|
|
||
| static bool do_poll_handler; |
Member
There was a problem hiding this comment.
Probably should be volatile if pbdrv_bluetooth_btstack_run_loop_trigger() is called from IRQ handlers.
Comment on lines
+232
to
+236
| info.hci_version = rp[1]; | ||
| info.hci_revision = pbio_get_uint16_le(&rp[2]); | ||
| info.lmp_pal_version = rp[4]; | ||
| info.manufacturer = pbio_get_uint16_le(&rp[5]); | ||
| info.lmp_pal_subversion = pbio_get_uint16_le(&rp[7]); |
Member
There was a problem hiding this comment.
It wouldn't hurt to put this unpacking in a separate function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help us with #435, so we can avoid inserting POSIX code directly into
bluetooth_btstackwith#ifs. It also makes us use the standard BTstack IRQ poll mechanism to simplify the next step.There is also an
inithook that runs before any btstack code runs. This should help avoid having to do things likestatic bool already_ran = false; already_ran = already_ranjust to get something to run once. This is where we could parse environment variables or set up logging, etc.