Skip to content

Robotics.py: Fix issue with the type stub for DriveBase.angle() #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlech merged 3 commits into from
Sep 20, 2025
Merged

Robotics.py: Fix issue with the type stub for DriveBase.angle() #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57caec1
Update robotics.py
shaggysa Sep 19, 2025
f638f64
test_get_signature.py update DriveBase.angle
shaggysa Sep 19, 2025
c7469d2
CHANGELOG.md: add typestub fix
shaggysa Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@

## Unreleased

### Fixed

- Fixed `DriveBase.angle` reporting an incorrect return type.

## 3.6.1 - 2025-05-01

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion jedi/tests/test_get_signature.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1020,7 +1020,7 @@ def _get_method_signature(module: str, type: str, method: str) -> SignatureHelp:
pytest.param("pybricks.robotics", "DriveBase", "stop", [([], "None")]),
pytest.param("pybricks.robotics", "DriveBase", "brake", [([], "None")]),
pytest.param("pybricks.robotics", "DriveBase", "distance", [([], "int")]),
pytest.param("pybricks.robotics", "DriveBase", "angle", [([], "int")]),
pytest.param("pybricks.robotics", "DriveBase", "angle", [([], "float")]),
pytest.param(
"pybricks.robotics", "DriveBase", "state", [([], "Tuple[int, int, int, int]")]
),
Expand Down
4 changes: 2 additions & 2 deletions src/pybricks/robotics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,8 @@ def distance(self) -> int:
Driven distance since last reset.
"""

def angle(self) -> int:
"""angle() -> int: deg
def angle(self) -> float:
"""angle() -> float: deg

Gets the estimated rotation angle of the drive base.

Expand Down