fix(tests): make async callback test deterministic#5986
Merged
rwgk merged 1 commit intopybind:masterfrom Feb 17, 2026
Merged
Conversation
Replace the fixed sleep in test_async_callbacks with a bounded wait for all expected callback results, so detached worker scheduling no longer causes sporadic CI failures. Co-authored-by: Cursor <cursoragent@cursor.com>
rwgk
force-pushed
the
fix_test_async_callbacks_race
branch
from
3c786f7 to
7af0782
Compare
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Feb 17, 2026
Collaborator
Author
|
Testing under #5988 was successful: Merging 4th of 4 PRs in quick succession. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the fixed sleep in test_async_callbacks with a bounded wait for all expected callback results, so detached worker scheduling no longer causes sporadic CI failures.
xref: #5985 (comment)
Suggested changelog entry: