Skip to content

Allow generation of keys of different types in the same session#227

Merged
MatthiasValvekens merged 3 commits intopyauth:masterfrom
Legrandin:fix_226
Apr 13, 2026
Merged

Allow generation of keys of different types in the same session#227
MatthiasValvekens merged 3 commits intopyauth:masterfrom
Legrandin:fix_226

Conversation

@Legrandin
Copy link
Copy Markdown
Contributor

@Legrandin Legrandin commented Apr 12, 2026

Fix #226

@Legrandin Legrandin changed the title Fix bug 226 Allow generation of keys of different types in the same session Apr 12, 2026
@MatthiasValvekens
Copy link
Copy Markdown
Collaborator

Oof, good catch. Can we have a regression test as well? :)

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 12, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.54%. Comparing base (1ff2114) to head (51bdf34).
⚠️ Report is 13 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #227      +/-   ##
==========================================
+ Coverage   90.17%   91.54%   +1.37%     
==========================================
  Files          15       15              
  Lines        2625     2674      +49     
  Branches       29       27       -2     
==========================================
+ Hits         2367     2448      +81     
+ Misses        255      224      -31     
+ Partials        3        2       -1     
Flag Coverage Δ
unittests 91.54% <100.00%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Legrandin
Copy link
Copy Markdown
Contributor Author

Sure, here it is. I actually had it but forgot to add it.

@MatthiasValvekens MatthiasValvekens merged commit 0af82a3 into pyauth:master Apr 13, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeMapper leaks RSA template attributes into later EC key generation calls (and vice versa)

3 participants