Skip to content

feat: make SignalGroupDescriptor generic#297

Open
tlambert03 wants to merge 11 commits intopyapp-kit:mainfrom
tlambert03:generic-sig-group-decriptor
Open

feat: make SignalGroupDescriptor generic#297
tlambert03 wants to merge 11 commits intopyapp-kit:mainfrom
tlambert03:generic-sig-group-decriptor

Conversation

@tlambert03
Copy link
Copy Markdown
Member

This PR is carrying on what I tried to do in #291.

It all works, but makes for an unappealing consequence when annotating with ClassVar[SignalGroupDescriptor] as described in #291 (comment)

working on it here

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Mar 11, 2024

CodSpeed Performance Report

Merging #297 will not alter performance

Comparing tlambert03:generic-sig-group-decriptor (50ab2f6) with main (8bf2d82)

Summary

✅ 67 untouched benchmarks

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 11, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.83%. Comparing base (8bf2d82) to head (50ab2f6).
⚠️ Report is 29 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   99.82%   99.83%           
=======================================
  Files          22       22           
  Lines        2351     2353    +2     
=======================================
+ Hits         2347     2349    +2     
  Misses          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants