Fix posts URL failures in link checker#868
Merged
Merged
Conversation
willingc
approved these changes
May 25, 2026
Collaborator
willingc
left a comment
There was a problem hiding this comment.
Love the solution. Thanks @banesullivan.
Member
|
thank you @banesullivan !!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's link checker fails on every new blog post. HTMLProofer and lychee fetch the absolute self-URL emitted by
_layouts/single.html(https://www.pyopensci.org/blog/<post>.html) before the page is deployed, so they 404. Excluding the self-domain in both tools clears the false failures.Separately,
_config.ymllisted_postsunderinclude:. Jekyll already collects_postsas a built-in, so every post was processed twice and the build emitted "destination shared by multiple files" warnings. Removing the duplicate entry clears them.Link checkers will no longer flag internal links written as absolute
https://www.pyopensci.org/...URLs. Internal links should use relative paths anyway and are validated against the local_sitebuild.