Skip to content

Comments

Add aod and clearsky_index to glossary, link terms in spectrum.rst#2663

Merged
cwhanse merged 15 commits intopvlib:mainfrom
RDaxini:glossary_definitions
Feb 19, 2026
Merged

Add aod and clearsky_index to glossary, link terms in spectrum.rst#2663
cwhanse merged 15 commits intopvlib:mainfrom
RDaxini:glossary_definitions

Conversation

@RDaxini
Copy link
Member

@RDaxini RDaxini commented Jan 21, 2026

  • Closes Add aod and clearsky_index to glossary #2564
  • I am familiar with the contributing guidelines
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Additional edit: fixed line length of some of the other definitions. Not strictly a flake8 failure but I think it looks neater and more readable.

@RDaxini RDaxini added this to the v0.14.1 milestone Jan 21, 2026
Copy link
Member

@echedey-ls echedey-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sexy PR @RDaxini , thanks. Some observations down below, but I'm okay with current status as is.

Comment on lines 23 to 31
aod
aod500
aerosol optical depth. Measure of aerosols (e.g., smoke
particles, desert dust) distributed within a column of air from the
instrument (Earth's surface) to the top of the atmosphere. The AOD
value indicates the level of extinction of sunlight in this column, and
when followed by a number (e.g. AOD500), indicates the extinction at
this wavelength (500nm). [unitless]

Copy link
Member

@echedey-ls echedey-ls Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it described by these equations? https://en.wikipedia.org/wiki/Optical_depth#Spectral_optical_depth

I have trouble finding PV specific information on a mathematical relationship. At least that is the only missing piece for me.

@kandersolar kandersolar modified the milestones: v0.14.1, v0.15.1 Jan 26, 2026
@RDaxini RDaxini marked this pull request as ready for review February 6, 2026 20:13
@RDaxini
Copy link
Member Author

RDaxini commented Feb 17, 2026

@cwhanse could you try rerunning the docs build?

RDaxini and others added 2 commits February 17, 2026 13:11
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
@cwhanse cwhanse merged commit c14dd73 into pvlib:main Feb 19, 2026
31 checks passed
@RDaxini RDaxini deleted the glossary_definitions branch February 19, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add aod and clearsky_index to glossary

4 participants