fix: UV - fund migration vote races on balance re-query#248
Merged
Conversation
Brings PR #209 (pushchain/push-chain-node) onto audit-fixes for audit review. The migration sweep amount is computed at signing time from the old vault's balance, but the broadcast path was re-querying the balance — racing with another validator's successful sweep would produce a different sweep amount and a different signed tx hash. - UnsignedSigningReq: add TSSFundMigrationAmount carried alongside Nonce from signing to broadcast (both are signing-time-decided values that must reach broadcast unchanged) - EVM tx_builder: store maxTransfer in the signing request; broadcast reuses it verbatim instead of recomputing - sessionmanager: persist and forward TSSFundMigrationAmount through the signing session - txbroadcaster: pass the stored amount to the broadcast call
Aman035
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings PR #209 (
fix: Fund migration vote) ontoaudit-fixesfor audit review.The migration sweep amount is computed at signing time from the old vault's balance, but the broadcast path was re-querying the balance — racing with another validator's successful sweep would produce a different sweep amount and a different signed tx hash, so the vote would never reach quorum.
Changes
UnsignedSigningReq(universalClient/chains/common/types.go): addTSSFundMigrationAmountcarried alongsideNoncefrom signing to broadcast (both are signing-time-decided values that must reach broadcast unchanged).tx_builder: storemaxTransferin the signing request; broadcast reuses it verbatim instead of recomputing from a re-queried balance.sessionmanager: persist and forwardTSSFundMigrationAmountthrough the signing session (+ tests).txbroadcaster: pass the stored amount through to the broadcast call (+ tests).Origin
Cherry-picked from squash-merge commit
e9c68675onmain(PR #209). Fixes the same race surfaced by issue #208.Test plan
go build ./...cleango test ./universalClient/tss/sessionmanager/... ./universalClient/tss/txbroadcaster/... ./universalClient/chains/evm/...— all pass locally