(PA-8499) Relax commander constraint#258
Merged
Merged
Conversation
1 task
isaac-jha
approved these changes
May 21, 2026
joshcooper
reviewed
May 21, 2026
In Ruby 3.4, abbrev was promoted from a default gem to a bundled gem. highline 1.x/2.x require abbrev and now fail to load under Ruby 3.4 unless an explicit dependency on it is declared. highline 3.0 removed that dependency. commander pins highline transitively: 4.x requires highline ~> 2.0, and only commander 5.0 requires highline ~> 3.0. Relaxing the upper bound to '< 6' lets vmfloaty resolve to highline 3.x on Ruby 3.4+ while still allowing commander 4.x for older consumers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
mhashizume
force-pushed
the
PA-8499/main/relax-commander-constraint
branch
from
062e89e to
dbcde7a
Compare
mhashizume
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Ruby 3.4,
abbrevwas promoted from a default gem to a bundled gem.highline1.x/2.x requireabbrevand now fail to load under Ruby 3.4 unless an explicit dependency on it is declared.highline3.0 removed that dependency.commanderpinshighlinetransitively: 4.x requireshighline ~> 2.0, and onlycommander5.0 requireshighline ~> 3.0. Relaxing the upper bound to< 6lets vmfloaty resolve tohighline3.x on Ruby 3.4+ while still allowingcommander4.x for consumers that need it.This unblocks consumers (e.g.
beaker-abs) that need to pull inhighline >= 3.0for Ruby 3.4+ support.Jira: PA-8499
Changes
vmfloaty.gemspec:commander '>= 4.4.3', '< 4.7.0'→commander '>= 4.4.3', '< 6'Gemfile.lock: commander 4.6.0 → 5.0.0, highline 2.0.3 → 3.0.1 (bundler resolves to the newest version in range)Test plan
Notes
Closes #211 (the open dependabot PR that proposed the more conservative `< 5.1.0` cap).
🤖 Generated with Claude Code