Skip to content

Conversation

@savetheclocktower
Copy link

Proceeding down my checklist, here's the next package to start publishing to NPM.

Copied what was done for less-cache; seems like it'll work just fine, but I suppose we'll find out.

@savetheclocktower
Copy link
Author

FYI: Currently Pulsar stable is pinned to an old commit of fuzzy-native, but I see nothing above it in the commit history that seems like it would break if we tried to publish current master.

If we're worried about it, we should increment the major version number before the first publish; that would give us room to do a “backport” publish. (For instance: publish the tip of master as 1.3.0. Then, if it fails: checkout the old commit, cherry-pick this PR, bump to 1.2.2, then create a release based off of that branch. Hopefully GitHub lets you generate releases from non-master branches.)

Copy link
Member

@confused-Techie confused-Techie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Lets get this one merged, and I'll also ensure this repository has access to our org secret NPM_PUBLISH_TOKEN

@savetheclocktower
Copy link
Author

Thanks for the review! In general, when you approve these, please merge them also, since I largely do not have access to do so.

@savetheclocktower savetheclocktower merged commit 1c3cac0 into pulsar-edit:master Sep 1, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants