Open
Conversation
8a31cf1 to
1f7d14e
Compare
Member
|
I wonder if we could add this to the login viewset in a useful way. That would mean the users viewset keeps being admins only, and users only ever interact with the login. We could even use a serializer that asks for the old, the new and a confirmation of the new password (when thinking about ui...), still allowing an admin to just (re-)set a users password. |
josephtate
approved these changes
Apr 15, 2026
josephtate
left a comment
There was a problem hiding this comment.
Yes, this looks like "just enough"
Contributor
Author
|
@mdellweg I did your suggestion, put it as a patch call to /login. Let me know if you have any concerns |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow users to update their password without needing admin permission.
📜 Checklist
See: Pull Request Walkthrough