Enable DELETE on the Docker v2 manifest endpoint#2377
Open
gerrod3 wants to merge 8 commits into
Open
Conversation
Allow users to delete manifests by digest via the registry API, with recursive removal of related tags and content from push repositories. fixes: pulp#480 Co-authored-by: Cursor <cursoragent@cursor.com>
Obtain the manifest digest via HEAD instead of inspect after push, since tag_and_push removes the local image. Poll until the manifest is gone after delete because removal runs asynchronously. Co-authored-by: Cursor <cursoragent@cursor.com>
Wait for the pushed manifest to appear before reading its digest, and send unauthenticated DELETE requests directly instead of via get_response. Co-authored-by: Cursor <cursoragent@cursor.com>
Wait for the pushed tag via repository API instead of registry HEAD, which is unreliable during async push completion in CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
Resolve manifests through repository tags when they are not directly present in the repository version, and tighten functional test setup. Co-authored-by: Cursor <cursoragent@cursor.com>
Avoid picking up CI netrc credentials by disabling trust_env when sending an unauthenticated DELETE request. Co-authored-by: Cursor <cursoragent@cursor.com>
Use gen_user and local_registry.get_response like other RBAC registry tests instead of raw requests.delete with trust_env, which is invalid and could authenticate as admin via RemoteUser in CI. fixes: pulp#480 Co-authored-by: Cursor <cursoragent@cursor.com>
Users without push permissions may receive 403 Forbidden instead of 401 Unauthorized depending on the storage backend configuration. fixes: pulp#480 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE /v2/<name>/manifests/<digest>support to the registry APITest plan
202 Accepted400 INVALID_REQUEST401Made with Cursor