Upgrade Node module dependencies#27
Open
christianbundy wants to merge 2 commits intopull-stream:masterfrom
Open
Upgrade Node module dependencies#27christianbundy wants to merge 2 commits intopull-stream:masterfrom
christianbundy wants to merge 2 commits intopull-stream:masterfrom
Conversation
christianbundy
commented
Sep 17, 2019
| pull.values(['x', 'y', 'z']), | ||
| pull.through(null, function (err) { | ||
| if(_err) { | ||
| t.strictEqual(err, _err); |
Member
Author
There was a problem hiding this comment.
I also made this change. I think that err and _err are identical objects, but they were failing because {} !== {}. The actual error is stored in .error, so I've changed this test to compare that property instead.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed a security advisory regarding the
wsmodule coming from this repo, so I went through and ensured that all of the npm dependencies were 100% up-to-date. It looks like the incompatibilities were caused byupgradeReqbeing removed, but the solution was pretty simple.