Skip to content

fix: handle 404 gracefully when a governance team does not exist #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lsmith77 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: handle 404 gracefully when a governance team does not exist #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8939,8 +8939,17 @@ function getCommandsFromComment(body) {
exports.getCommandsFromComment = getCommandsFromComment;
function inTeam(org, username, team) {
return __awaiter(this, void 0, void 0, function* () {
const members = yield octokit_1.default.teams.listMembersInOrg({ org, team_slug: team });
return members.data.map(m => m.login).includes(username);
try {
const members = yield octokit_1.default.teams.listMembersInOrg({ org, team_slug: team });
return members.data.map(m => m.login).includes(username);
}
catch (e) {
if (e.status === 404) {
console.warn(`404 while fetching members of '${team}' team`);
return false;
}
throw e;
}
});
}
exports.inTeam = inTeam;
Expand Down
13 changes: 11 additions & 2 deletions src/bot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,18 @@ export function getCommandsFromComment(body: string): Command[] {
}

export async function inTeam(org: string, username: string, team: string) {
const members = await octokit.teams.listMembersInOrg({ org, team_slug: team });
try {
const members = await octokit.teams.listMembersInOrg({ org, team_slug: team });

return members.data.map(m => m.login).includes(username);
} catch (e) {
if ((e as RequestError).status === 404) {
console.warn(`404 while fetching members of '${team}' team`);
return false;
}

return members.data.map(m => m.login).includes(username);
throw e;
}
}

export async function isMaintainer(org: string, username: string) {
Expand Down