Detect exit() from coroutine/fiber alternate stack and convert to emu quit#3571
Open
zqb-all wants to merge 1 commit intoptitSeb:mainfrom
Open
Detect exit() from coroutine/fiber alternate stack and convert to emu quit#3571zqb-all wants to merge 1 commit intoptitSeb:mainfrom
zqb-all wants to merge 1 commit intoptitSeb:mainfrom
Conversation
… quit When exit() is called with RSP outside the known main stack range (emu->init_stack/size_stack), convert to emu->quit instead of killing the process. This handles custom coroutine libraries that call exit() as a safety fallback from malloc'd alternate stacks.
Owner
|
I am wondering if that code emu->quit = 1;
R_EAX = code;should be how my_exit should be handled all the time. I'll do some testing on my side before merging this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When exit() is called with RSP outside the known main stack range (emu->init_stack/size_stack), convert to emu->quit instead of killing the process. This handles custom coroutine libraries that call exit() as a safety fallback from alternate stacks.