Fix MacOS Clang 17+ compile issue #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This patch fixes build issues on newer macOS systems (like Apple Silicon Macs running Clang 17 or higher). It adds --with-system-zlib which avoids problems with fdopen() in zlib.
Why it's needed
Clang 17+ doesn’t play nice with the bundled zlib—it causes build errors because of a missing fdopen() macro. Using the system zlib fixes that.
Tested on
macOS Sonoma (M4 Mac Mini)
Homebrew + Clang 17+