ATAD: fix device probing for slave device#858
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes device probing for ATA slave device in
ata_init_devices.ata_device_probe writes to ATA registers after checking
nsector,sector,hcylandlcylvalues:ps2sdk/iop/dev9/atad/src/ps2atad.c
Lines 1204 to 1207 in f388f51
As it turns out, simply switching from device 0 to device 1 does not clear the ATA controller register values. This causes probing for device 1 to reuse register values from the previous
ata_device_probecall.Resetting the ATA controller before calling
ata_device_selectfixes this.Before the change, device 1 was ignored.
After the change, probing correctly handles all cases, including setups with a missing master device.