Document proxy_set_shared_data(key, NULL) (remove).#100
Open
PiotrSikora wants to merge 2 commits intoproxy-wasm:mainfrom
Open
Document proxy_set_shared_data(key, NULL) (remove).#100PiotrSikora wants to merge 2 commits intoproxy-wasm:mainfrom
proxy_set_shared_data(key, NULL) (remove).#100PiotrSikora wants to merge 2 commits intoproxy-wasm:mainfrom
Conversation
Contributor
|
IIUC from discussion here, we are leaning towards not adding this, and sticking to a more minimal API where removal is expressed by passing a value of null. |
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
Signed-off-by: Piotr Sikora <code@piotrsikora.dev>
PiotrSikora
force-pushed
the
kvstore_remove
branch
from
7e04629 to
8f29770
Compare
PiotrSikora
changed the title
proxy_set_shared_data(key, NULL) (remove).
Member
Author
Correct. Documented this behavior in the updated version of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.