Skip to content

Full Abseil + RE2 support#173

Merged
martijneken merged 7 commits intoproxy-wasm:mainfrom
martijneken:abseil-re2-fix
Oct 25, 2024
Merged

Full Abseil + RE2 support#173
martijneken merged 7 commits intoproxy-wasm:mainfrom
martijneken:abseil-re2-fix

Conversation

@martijneken
Copy link
Copy Markdown
Contributor

@martijneken martijneken commented Oct 10, 2024 •
edited
Loading

Fixes #175

Related cleanups:

  • Simpler Docker container
  • Single Makefile
  • Support for -flto
  • Proto upgrade to v26.1
  • Updated build docs
  • More/independent examples
  • Remove protobuf CI check

Notes

  • Depends on Emscripten update in Fix SDK Docker build scripts, update Emscripten #172.
  • Found that absl::random doesn't work yet, will send a follow-up patch to implement getentropy
  • Deferring Bazel protobuf update, since this requires Bazel toolchain updates (FWIW Bazel/Make protobuf versions are already out of sync)

@martijneken martijneken mentioned this pull request Oct 10, 2024
Merged
@martijneken
Fix Abseil + RE2 support
cf82fb7 
Depends on Emscripten update in proxy-wasm#172.

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Remove docs covering lack of Abseil support
668c5f3 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken
Fix dupe linker opt, add TODO for Docker builds
d505642 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken mentioned this pull request Oct 10, 2024
Closed
@martijneken
Add RE2 example.
df8faa9 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
This was referenced Oct 16, 2024
Merged
Closed
@martijneken
Full support for RE2 and Abseil!
ed827a4 
- Simpler Docker container
- Single Makefile
- Support for -flto
- Proto upgrade to v26.1
- Updated build docs

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken changed the title Fix Abseil + RE2 support Full Abseil + RE2 support Oct 19, 2024
@martijneken
Cleanup
81c472c 
- add license headers to generated files
- update Bazel builds for examples
- remove unnecessary protobuf binary CI check

Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken marked this pull request as ready for review October 19, 2024 05:23
@martijneken martijneken requested a review from leonm1 October 21, 2024 14:09
mpwarres
mpwarres approved these changes Oct 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mpwarres mpwarres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool!

@martijneken
Tweak Makefile, mostly formatting
7db1e81 
Signed-off-by: Martijn Stevenson <mstevenson@google.com>
@martijneken martijneken merged commit 9dc95ae into proxy-wasm:main Oct 25, 2024
@martijneken martijneken deleted the abseil-re2-fix branch October 25, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpwarres mpwarres mpwarres approved these changes

@PiotrSikora PiotrSikora Awaiting requested review from PiotrSikora PiotrSikora is a code owner

@leonm1 leonm1 Awaiting requested review from leonm1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Abseil/RE2 in Bazel + Docker

2 participants

@martijneken @mpwarres