Update Roads.java: exclude 'platform_edge' from railways#547
Open
pietervdvn wants to merge 6 commits intoprotomaps:mainfrom
Open
Update Roads.java: exclude 'platform_edge' from railways#547pietervdvn wants to merge 6 commits intoprotomaps:mainfrom
pietervdvn wants to merge 6 commits intoprotomaps:mainfrom
Conversation
migurski
requested changes
Feb 3, 2026
Collaborator
migurski
left a comment
migurski
left a comment
There was a problem hiding this comment.
This change looks good, really appreciate it. Would you be able to address the linter feedback so it can be merged?
Collaborator
|
Adding a render test here: pietervdvn#1 |
Add render test for railway platform edge
|
Contributor
Author
|
I've addressed the linter feedback, but, to be a bit blunt: why bother? The tooling can do this fully automatically. IMHO, automatically linting/formatting the codebase every now and then can be done with a script without having to do another round of feedback to me. (For context: I simply made the changes in the web editor without setting up the dev environment) |
Contributor
Author
|
I've also merged (and fixed) in the render test by @wipfli |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently, some people add the edge of platforms into OpenStreetMap.
This was picked up as "railway", giving extra railways renderings where there are none (the two "dead end" railways should dissappear):
This PR excludes them from tile generation