Open
Conversation
wipfli
commented
May 27, 2025
| "scrub", | ||
| "grassland", | ||
| "grass", | ||
| "glacier", |
Collaborator
Author
There was a problem hiding this comment.
We forgot this one in the past. Now high-zoom glaciers are visible again. Maybe I should add a render test for this...
Member
There was a problem hiding this comment.
Yes, I think the render test is most useful for this class of issue, but do we have enough data in the CI sample data?
Collaborator
Author
There was a problem hiding this comment.
Not yet but I an create a slice
Collaborator
Author
There was a problem hiding this comment.
Added a render test for glaciers
|
jgillich
reviewed
Aug 20, 2025
| ["get", "kind"], | ||
| ["literal", ["wood", "nature_reserve", "forest"]], | ||
| ], | ||
| t.wood_b, |
There was a problem hiding this comment.
I just noticed that this removes the use of the wood color. Was that intentional? Seems like a useful distinction to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Fixes the parks issue in Amsterdam reported in #433