Fix MessageSet recursion depth propagation in Python decoder#26710
Open
steadytao wants to merge 2 commits intoprotocolbuffers:mainfrom
Open
Fix MessageSet recursion depth propagation in Python decoder#26710steadytao wants to merge 2 commits intoprotocolbuffers:mainfrom
steadytao wants to merge 2 commits intoprotocolbuffers:mainfrom
Conversation
Preserve current_depth when MessageSet decoders recurse into unknown groups so the recursion limit is enforced consistently. Add regression coverage for MessageSet and unknown MessageSet item depth propagation.
Author
|
The fork safety gate appears to be blocking CI before the actual test matrix runs. Could a protobuf maintainer please add the |
esrauchg
reviewed
Apr 6, 2026
Contributor
esrauchg
left a comment
There was a problem hiding this comment.
Thanks for the proposal!
Require explicit current_depth for UnknownMessageSetItemDecoder callers and fix the decoder test to avoid runtime-specific private fields.
Author
|
Removed the implicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve recursion depth accounting when Python MessageSet decoders recurse into unknown groups.
Problem
MessageSetItemDecoderandUnknownMessageSetItemDecodercalled_DecodeUnknownField(...)without forwardingcurrent_depth.That reset recursion accounting in the unknown-group path and allowed MessageSet parsing to bypass the intended nesting limit in this specific case.
Fix
current_depthfromMessageSetItemDecodercurrent_depthfromUnknownMessageSetItemDecoderTesting
DecodeErrorwhen recursion depth is already exhaustedFixes #26437