Skip to content
This repository was archived by the owner on Aug 29, 2023. It is now read-only.

Conversation

@marten-seemann
Copy link
Contributor

@marten-seemann marten-seemann commented Apr 1, 2021

Depends on #145, as it used the get-repos script.

This is the script that was used to generate the Go Repo Health spreadsheet, now with an added column indicating if web3-bot already created a PR or not.

@marten-seemann marten-seemann marked this pull request as ready for review July 26, 2021 19:13
return
fi
diff go.sum go.sum.orig > /dev/null
echo $?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why echo? We could just do what we do for the other commands (capture the return status)

for repo in $(node get-repos/index.js -l Go | jq -r '.[]'); do
tmp=$(mktemp -d)
pushd $tmp > /dev/null
git clone -q https://github.com/$repo .
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so... it would be nice if there were a way to tell this to clone from local repos... E.g., from a gopath.

Maybe just make the https://github.com part configurable?

echo "$repo $numcommits true"
fi
fi
popd > /dev/null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd honestly just run this all in a subshell unless we need it to be in the main shell. I.e., replace the push/pop with

(
...
)

@galargh
Copy link
Contributor

galargh commented Feb 23, 2023

We haven't been using this script in a while, and we do try to cover new Go repos as soon as they're created, but it might be interesting to run it and see what's the situation with the repos that are yet not covered. I'm going to merge it as-is as it's not on a critical path.

@galargh galargh merged commit 8fde398 into master Feb 23, 2023
@galargh galargh deleted the repo-health branch February 23, 2023 13:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants