Optionaly recognize modifyOtherKey (ctrl-, ctrl-shift-)#2066
Draft
Carreau wants to merge 1 commit intoprompt-toolkit:mainfrom
Draft
Optionaly recognize modifyOtherKey (ctrl-, ctrl-shift-)#2066Carreau wants to merge 1 commit intoprompt-toolkit:mainfrom
Carreau wants to merge 1 commit intoprompt-toolkit:mainfrom
Conversation
As far as I can tell, many terminal support this, and it allows (when enabled) to distinguish some modifier that are otherwise impossible to detect. In particular there is often a request in IPython to distinguish Ctrl-Enter. This _should_ be 100% backward compatible. Ctrl-Shift- is _not_ added as many terminal don't actually support it. This is gated by a context manager `modify_other_keys` that is widely supported. Some discussion I found about why / or why not : `https://github.com/ghostty-org/ghostty/issues/242`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell, many terminal support this,
and it allows (when enabled) to distinguish some modifier that are otherwise impossible to detect.
In particular there is often a request in IPython to distinguish Ctrl-Enter.
This should be 100% backward compatible.
Ctrl-Shift- is not added as many terminal don't actually support it.
This is gated by a context manager
modify_other_keysthat is widely supported.Some discussion I found about why / or why not :
https://github.com/ghostty-org/ghostty/issues/242related to ipython/ipython#13879
I tried state 2 but this would be much more invasive to detect all the keys, any anyway if we go further I think support for https://sw.kovidgoyal.net/kitty/keyboard-protocol/ directly will be good as there is extensive documentation on how to detect it and have progressive enhancement.
Leaving as draft for now