Skip to content

ci: pin contents: read on md-validation and openmetrics#2989

Open
arpitjain099 wants to merge 1 commit into
prometheus:mainfrom
arpitjain099:ci/add-permissions
Open

ci: pin contents: read on md-validation and openmetrics#2989
arpitjain099 wants to merge 1 commit into
prometheus:mainfrom
arpitjain099:ci/add-permissions

Conversation

@arpitjain099
Copy link
Copy Markdown

Pins the default GITHUB_TOKEN to read-only on the two PR-time validation workflows. Both only checkout and run local scripts (make check for markdown link checking, ABNF validator for the OpenMetrics 2.0 spec); no GitHub API writes.

Copy link
Copy Markdown
Contributor

@jan--f jan--f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense. @arpitjain099 once you sign the commit to pass the DCO test we can merge this.

Both workflows are PR-time read-only checks: markdown link checking
and ABNF validation of the OpenMetrics 2.0 spec.

Signed-off-by: arpitjain099 <arpitjain099@gmail.com>
@arpitjain099
Copy link
Copy Markdown
Author

This makes sense. @arpitjain099 once you sign the commit to pass the DCO test we can merge this.

@jan--f thanks! I signed the DCO. Please check again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants