Skip to content

fix: remove version manipulation from build-release.sh #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeitlinger merged 1 commit into from
Feb 18, 2026
Merged

fix: remove version manipulation from build-release.sh #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ jobs:

- name: Build release version
run: mise run build-release
env:
TAG: ${{ github.ref_name }}

- name: Set up Apache Maven Central
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654 # v5
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test-release-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,3 @@ jobs:
BASE_URL: "/client_java"
- name: Build release version
run: mise run build-release
env:
# don't use the current snapshot version, to test a more realistic release
TAG: ${{ github.run_number }}
18 changes: 2 additions & 16 deletions .mise/tasks/build-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,8 @@
#!/usr/bin/env bash

#MISE description="Build release package"
#USAGE arg "[tag]" env="TAG"

set -euo pipefail

PARENT_POM="prometheus-metrics-parent/pom.xml"
CURRENT_VERSION=$(sed -n 's/.*<version>\(.*-SNAPSHOT\)<\/version>.*/\1/p' "$PARENT_POM" | head -1)

if [[ -z "$CURRENT_VERSION" ]]; then
echo "ERROR: could not find SNAPSHOT version in $PARENT_POM" >&2
exit 1
fi

# shellcheck disable=SC2154 # is set by mise
VERSION=${usage_tag:-$CURRENT_VERSION}
VERSION=${VERSION#v}

find . -name 'pom.xml' -exec \
sed -i "s/<version>${CURRENT_VERSION}<\/version>/<version>${VERSION}<\/version>/g" {} +
mvn -B package -P 'release,!default,!examples-and-integration-tests' -Dmaven.test.skip=true -Dgpg.skip=true
mvn -B package -P 'release,!default,!examples-and-integration-tests' \
-Dmaven.test.skip=true -Dgpg.skip=true