add system metadata labels#416
add system metadata labels#416cczhuang420 wants to merge 4 commits intoprometheus-community:masterfrom
Conversation
2d12d2c to
03d92bf
Compare
Signed-off-by: cczhuang420 <zhuangxiaoxiao1988@gmail.com>
Signed-off-by: cczhuang420 <zhuangxiaoxiao1988@gmail.com>
03d92bf to
f92d214
Compare
Signed-off-by: cczhuang420 <zhuangxiaoxiao1988@gmail.com>
Signed-off-by: cczhuang420 <zhuangxiaoxiao1988@gmail.com>
|
|
|
Sorry, I misunderstood this change. I think this needs more documentation and description as to why it is necessary. |
|
@SuperQ We also found it missing when using the project. System and user labels are part of the resources being monitored, and there's many use cases requiring filtering / grouping metrics by those types of labels. @cczhuang420 Could I ask that you also add user defined labels in this PR? As described in the API description, |
Hi folks, sorry that I couldn't manage to finish this given my current limited bandwidth, so have moved it to draft. I would need to test it more throughly before raising a PR. Feel free to close it. |
This PR is to export the system metadata labels along with metric and resource labels.