-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for managing Cilium EE patch version via OLM on OpenShift 4 #201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdebb64 to
b0f5429
Compare
simu
commented
Jan 21, 2026
d303d4b to
a43f4ae
Compare
DebakelOrakel
approved these changes
Jan 23, 2026
…uster bootstrap We probably still need to deploy the OLM clife-controller-manager deployment during cluster bootstrap (needs testing). But once the deployment is managed by the OLM, we don't want ArgoCD to manage it anymore, since we end in a reconcile loop between OLM and ArgoCD otherwise. This commit introduces parameter `olm.upgrade_strategy.generate_olm_deployment` to control rendering of the OLM deployment with `generate_subscription=true`
a43f4ae to
27518f4
Compare
The Cilium 1.17 manifests don't have that field, while the 1.16 manifests do. I'm not sure whether the field actually causes issues if the referenced CSV doesn't exist, but since everything seems to work fine without it, we just drop it if it's present in the input manifest.
…based patch upgrades
27518f4 to
3d74335
Compare
|
🚀 This PR has been released as Triggering workflows 🛠️ Auto tagging enabled with label |
bastjan
approved these changes
Jan 23, 2026
Member
bastjan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.