Drop tests formatting month name using Temporal & iso8601 calendar #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of Intl.DateTimeFormat when formatting with the
iso8601calendar is under active discussion in tc39/ecma402#1036, and we should not encode expectations about how it deals with long month names.Also, these tests fail for me locally with Node.js 25.2.1 on MacOS, with ICU 78.1. The CI tests include a successful run with Node.js 25.2.1 on Linux, but I'm not sure if/whether the ICU versions differ between platforms. Or if there's some other reason why the behaviour differs.