Skip to content

Fix type safety for FluentVariable #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eemeli merged 2 commits into from
Nov 27, 2025
Merged

Fix type safety for FluentVariable #649

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71f6922
Stricter types for FluentVariable
Demivan Nov 16, 2025
78b9f19
Remove rendundant type assertion
Demivan Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions fluent-bundle/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,22 @@ import { Scope } from "./scope.js";
// Replace with Temporal.* types once they are provided by TypeScript
// In addition to this minimal interface, these objects are also expected
// to be supported by Intl.DateTimeFormat
interface TemporalObject {
epochMilliseconds?: number;
interface TemporalInstant {
epochMilliseconds: number
toString(): string;
}
interface TemporalDateTypes {
calendarId: string;
toZonedDateTime?(timeZone: string): { epochMilliseconds: number };
calendarId?: string;
toString(): string;
}
interface TemporalPlainTime {
hour: number
minute: number
second: number
toString(): string;
}
type TemporalObject = TemporalInstant | TemporalDateTypes | TemporalPlainTime

export type FluentValue = FluentType<unknown> | string;

Expand Down Expand Up @@ -207,7 +217,7 @@ export class FluentDateTime extends FluentType<number | Date | TemporalObject> {
if (value instanceof Date) return value.getTime();

if ("epochMilliseconds" in value) {
return value.epochMilliseconds as number;
return value.epochMilliseconds;
}

if ("toZonedDateTime" in value) {
Expand Down