Skip to content

Comments

fix(http11): disable HTTP/2 fallback for -pr http11 (Fixes #2240)#2417

Draft
wh0amibjm wants to merge 1 commit intoprojectdiscovery:devfrom
wh0amibjm:fix/http11-disable-http-fallback-2240
Draft

fix(http11): disable HTTP/2 fallback for -pr http11 (Fixes #2240)#2417
wh0amibjm wants to merge 1 commit intoprojectdiscovery:devfrom
wh0amibjm:fix/http11-disable-http-fallback-2240

Conversation

@wh0amibjm
Copy link

Fixes #2240

Summary:

  • When Protocol is forced to HTTP/1.1 ("-pr http11"), set retryablehttp-go option DisableHTTPFallback to prevent switching to the internal HTTP/2 fallback client on malformed HTTP/2 responses.

Note:

  • This PR depends on projectdiscovery/retryablehttp-go PR httpx gets stuck - No output #527 (adds Options.DisableHTTPFallback).
  • Until that PR is merged and a module version is available, CI may fail due to the missing field.

Tests (local, with temporary module replace):

  • go test ./common/httpx -count=1

/claim #2240

@coderabbitai
Copy link

coderabbitai bot commented Feb 22, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

-pr http11 flag is ignored on retryablehttp-go due to HTTP/2 fallback

2 participants