Skip to content

fix: respect -pr http11 flag by disabling HTTP/2 fallback in retryablehttp #2413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharkqwy wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

fix: respect -pr http11 flag by disabling HTTP/2 fallback in retryablehttp #2413

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/httpx/httpx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,17 @@ func New(options *Options) (*HTTPX, error) {
CheckRedirect: redirectFunc,
}, retryablehttpOptions)

// When HTTP/1.1 is explicitly requested, also disable HTTP/2 fallback
// in the retryablehttp client's secondary HTTP client to prevent
// automatic HTTP/2 upgrade on retry (see retryablehttp-go do.go).
if httpx.Options.Protocol == "http11" {
httpx.client.HTTPClient2 = &http.Client{
Transport: transport,
Timeout: httpx.Options.Timeout,
CheckRedirect: redirectFunc,
}
}

transport2 := &http2.Transport{
TLSClientConfig: &tls.Config{
InsecureSkipVerify: true,
Expand Down