Conversation
|
I can hear the audio and press the play and pause button on macOS. |
Thanks for test! |
There was a problem hiding this comment.
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/shared/audio_message_interface.rs:3707
- The branch for handling MediaSource::Encrypted is empty, which may lead to unhandled cases for encrypted audio. Please implement the necessary handling or add a clarifying comment explaining why it is intentionally left empty.
MediaSource::Encrypted(_e) => {
There was a problem hiding this comment.
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/audio/audio_controller.rs:183
- The magic number '44' is used as the default audio offset; consider defining it as a named constant to improve code readability and maintainability.
*self.selected.lock().unwrap() = Selected::Playing(*new_uid, 44);
There was a problem hiding this comment.
Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/audio/audio_controller.rs:183
- [nitpick] The magic number '44' is used as the initial/reset audio position; consider defining it as a named constant to clarify its purpose and improve maintainability.
Selected::Playing(*new_uid, 44);
Add encrypted audio message prompt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Ensure position is within bounds before accessing audio data Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Marking as blocked-on-makepad because most, if not all of this PR's content should be upstreamed into Makepad itself. |
Fixes #120
fix audio of issue120 Display multimedia messages: audio, video, stickers (gifs)
Fixed