WASI-Threads #12
Draft
WASI-Threads #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new way of spinning threads in wasm is through WASI-Threads, not with WAMR libpthread implementation. We switch it here. The -Wl,--max-memory=1048576 parameter is necessary, because lld will set it as default to 0 and not as unlimited, as stated in its documentation. We might need to adjust the maximum memory to be higher, but 1MB seems enough for now. Each thread needs 2 pages of memory (so 2x64KB). With 1MB we can have 8 threads. Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
force-pushed
the
wasi-threads
branch
from
5719984 to
103b799
Compare
Contributor
Author
|
Setting as draft until we officially enable WASI-Threads in Ocre. |
Signed-off-by: Marco Casaroli <marco.casaroli@gmail.com>
casaroli
force-pushed
the
wasi-threads
branch
from
f00ea50 to
2030fa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to WASI-Threads.
The new way of spinning threads in WASM is through WASI-Threads, not with WAMR libpthread implementation. We switch it here.
The -Wl,--max-memory=1048576 parameter is necessary, because lld will set it as default to 0 and not as unlimited, as stated in its documentation.
We might need to adjust the maximum memory to be higher, but 1MB seems enough for now.
Each thread needs 2 pages of memory (so 2x64KB). With 1MB we can have 8 threads.
Attention: this is a major breaking change. This change require WAMR to be compiled with
WAMR_BUILD_LIB_WASI_THREADS, which is not the current default in Ocre.