Fix #825 - Showing wrong errors' line numbers for .java files

[e1dem]

Using PreprocSketch.mapJavaToSketch result for processing .java files is incorrect, as a sketch's combined source code file does not include code from .java tabs.

As far as I can see, there is a similar issue with showing variables usage, so I would suggest this solution as a temporary one.

Closes #825 (originally at benfry/processing4#825)

[Stefterv]

Hi @e1dem! Thank you for your contribution, code looks good, testing now on macOS

[Stefterv]

Looking good!

[Stefterv]

@SableRaf Please take a look and merge if you understand what has changed!

[SableRaf]

@Stefterv: So, if I understand correctly, the changes ensure that we don't need the workaround to zero index for PDE tabs because Java tabs live in their own files, and the line number offset is now handled correctly. Did I get that right?

And does the fix still work when you have more than one Java tab?

[Stefterv]

Yes it works with more than one Java tab

Not sure what workaround you are referring to... But yes the line number offset is now handled correctly

[SableRaf]

Hmm then I'm not sure I understand 100%. If this is a low stakes change then it may be ok but if you need a stricter review, we might need another pair of eyes on this.

[Stefterv]

This is a low-stakes quality of life change
Basically it add an check in the convertIProblem() function that in case of a Java file gets the correct line numbering

[SableRaf]

@all-contributors please add @e1dem for code

[allcontributors]

@SableRaf

I've put up a pull request to add @e1dem! 🎉