Fix: Allow JDK folders starting with "jdk" or "jdk-" during export#1171
Fix: Allow JDK folders starting with "jdk" or "jdk-" during export#1171amankumar100 wants to merge 2 commits intoprocessing:mainfrom amankumar100:fix-1141
Conversation
The export logic in JavaBuild.java previously looked only for JDK folders starting with "jdk-". However, the embedded JDK may simply be named "jdk", causing path resolution to fail and no JRE to be bundled. This leads to macOS launch issues like JRExLoadFullError and JRELoadError. Updated the filter to also allow "jdk" prefixes.
Thanks for submitting this patch, and welcome! Just a heads-up: we ask that contributors get assigned to an issue before opening a PR. In this case, someone else is already assigned to the issue. I appreciate the effort you put into this. Since it's a small change, we're happy to review it and share feedback. However, we won't be merging this PR. |
|
Thanks for your interest in contributing @amankumar100. Just a reminder: if an issue is already assigned, it means someone is already working on it. You're still very welcome to join the conversation on the issue itself and offer solutions, that kind of input is also valuable. If you'd like to contribute code, please start with an unassigned issue. Before you do, make sure to build locally and test your changes. See BUILD.md for instructions. |

No description provided.