fix: support get() at pixel density > 1 in p5.Framebuffer (fixes #8583)#8584
Open
MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
Open
fix: support get() at pixel density > 1 in p5.Framebuffer (fixes #8583)#8584MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
MASTERsj01 wants to merge 1 commit intoprocessing:mainfrom
Conversation
- Replace lossy resize(w, h) with pixelDensity(density) on the returned p5.Image so that it retains full-resolution pixel data while reporting correct logical width and height - Replace console.warn with p5._friendlyError for out-of-bounds coordinate warning in get() - Remove TODO comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
p5.Framebuffer.get()to properly support pixel density > 1 by usingp5.Image.pixelDensity()instead of lossy resize().Resolves #8583
Problem
When
density > 1, get() reads the full high-resolution pixel data (e.g. 200×200 at density 2 for a 100×100 framebuffer) but then calls resize(100, 100) which performs a lossy downscale — discarding the extra resolution that high-DPI displays need.Fix
Replace resize(w, h) with pixelDensity(density) on the returned
p5.Image. This way the image retains its full-resolution data (200×200 pixels) while reporting the correct logical dimensions (100×100), matching how high-DPI images work throughout p5.js.Changes
console.warn→p5._friendlyError()for out-of-bounds warningTODOcommentNotes